Adding xHostsFile resource to close issue #8 #93
Conversation
|
Hi @rchaganti, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
| #endregion | ||
| } | ||
| finally | ||
| { |
There was a problem hiding this comment.
We should probably backup/restore the host file to clear out any modifications we made to it during the integration tests.
There was a problem hiding this comment.
Done! I am copying the file to $env:Temp and restoring it from there.
Updates to address feedback from @tysonjhayes.
| IPAddress = $IPAddress | ||
| } | ||
|
|
||
| Write-Verbose $localizedData.checkingHostsFileEntry |
There was a problem hiding this comment.
I hate to be a pain, but are we able to eliminate the use of any positional parameters? In general it is recommended against for production code (https://blogs.technet.microsoft.com/heyscriptingguy/2012/04/22/the-problem-with-powershell-positional-parameters/).
e.g. Change
Write-Verbose $localizedData.checkingHostsFileEntryto:
Write-Verbose -Message $localizedData.checkingHostsFileEntryThere was a problem hiding this comment.
:) No major problem there. I should have taken care of that. Will do now! :)
|
Nice work BTW - sorry to be nit picky about style. Thanks for working on this 👍 |
|
Do you know why the last build failed? It took more than 7hrs to fail and I don't see anything in the logs. Could be a build system issue? |
|
I've had this problem before (and so have others as well). It usually seems to occur during the PSScriptAnalyzer checks. No idea why it happens though. I usually just commit a "dummy" change to trigger a rebuild and it works fine. Just add a space to the end of the one of the "Changes" lines in the # Unreleased section of the readme.md or something like that and commit it. |
|
@PlagueHO that did the trick! :) |
|
Just a reminder - Please resolve merge conflicts. For more information see GitHowTo - 30. Resolving Conflicts |
|
I messed up my local repo while trying to resolve merge conflicts! A bit more of Github / Git expertise would have been helpful. I moved the HEAD to a well-known commit in my local repo however the pull request commit to the PowerShell/Dev is one commit ahead. I am unable to do a force merge. What are the other options? |
|
@rchaganti you could delete you local branch and fetch and checkout the branch from github. This should get you back to the state you PR is in. Here are some notes I usually point to on how to merge: |
|
Whatever I did! This thing resulted in a new PR! :( but a clean one. |
|
Looks like this PR is replaced by: |
|
Addressed in PR #98 |
No description provided.