Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Parameter name fixed #25

Closed
wants to merge 1 commit into from

Conversation

RobBiddle
Copy link
Contributor

@RobBiddle RobBiddle commented Nov 10, 2017

When applying xRDSessionCollection to an RDS Host which is not also a Connection Broker the following error is being thrown:

A parameter cannot be found that matches parameter name 'CollectionDescription'. + CategoryInfo : InvalidArgument: (:) [], CimException + FullyQualifiedErrorId : NamedParameterNotFound,Add-RDSessionHost + PSComputerName : localhost


This change is Reviewable

When applying *xRDSessionCollection* to an RDS Host which is not also a Connection Broker the following error is being thrown:

```
A parameter cannot be found that matches parameter name 'CollectionDescription'.
    + CategoryInfo          : InvalidArgument: (:) [], CimException
    + FullyQualifiedErrorId : NamedParameterNotFound,Add-RDSessionHost
    + PSComputerName        : localhost
```
@RobBiddle
Copy link
Contributor Author

Microsoft Contribution Licensing Agreement (CLA) has been signed

@ld0614
Copy link
Contributor

ld0614 commented Nov 13, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ld0614
Copy link
Contributor

ld0614 commented Nov 14, 2017

While everything about this change looks good I'd just like to run this past another maintainer as this is my first set of PRs since becoming a maintainer so want to doublecheck that everything is in order. @kwirkykat or another maintainer would you just be able to give this a once-over before I merge please?

@kwirkykat
Copy link
Contributor

@RobBiddle Can you please update the 'Unreleased' section of the README with a bullet point describing your change for the release notes?

@ld0614 ld0614 added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Nov 22, 2017
@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels May 7, 2018
@johlju
Copy link
Member

johlju commented May 23, 2018

Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.

@johlju johlju added abandoned The pull request has been abandoned. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels May 23, 2018
@johlju johlju closed this in #38 Jun 22, 2018
@johlju johlju removed the abandoned The pull request has been abandoned. label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants