-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/login mobile: finish UI and integrate API #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Resolve comments.
- Change title, branch, commit follow convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncomment onError, set null for authUserInfo to logout in case 401 instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment
@@ -14,6 +15,7 @@ import 'package:flutter_template/presentation/auth/bloc/register/register_bloc.d | |||
import 'package:flutter_template/presentation/widgets/custom_button.dart'; | |||
import 'package:flutter_template/presentation/widgets/header.dart'; | |||
import 'package:flutter_template/router/app_router.dart'; | |||
import 'package:hive/hive.dart'; | |||
|
|||
class PhoneInputView extends StatefulWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why datasource appear in presentation?
@@ -32,6 +34,9 @@ class _PinAuthenViewState extends State<PinAuthenView> { | |||
remoteDataSource: PatientRemoteDataSource( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why datasource appear in presentation?
child: Text( | ||
LocaleKeys.auth_forgot_password.tr(), | ||
style: context.labelMedium.copyWith( | ||
color: Theme.of(context).primaryColor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context.themeConfig.primaryColor
@@ -2,7 +2,8 @@ import 'package:flutter/material.dart'; | |||
import 'package:flutter_bloc/flutter_bloc.dart'; | |||
import 'package:flutter_template/common/extensions/context_extension.dart'; | |||
import 'package:flutter_template/generated/assets.gen.dart'; | |||
import 'package:flutter_template/presentation/auth/bloc/auth/auth_bloc.dart'; | |||
// import 'package:flutter_template/presentation/auth/bloc/auth/auth_bloc.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
import 'package:flutter_template/di/di.dart'; | ||
import 'package:flutter_template/flavors.dart'; | ||
import 'package:flutter_template/generated/codegen_loader.g.dart'; | ||
import 'package:flutter_template/presentation/auth/bloc/auth/auth_bloc.dart'; | ||
// import 'package:flutter_template/presentation/auth/bloc/auth/auth_bloc.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
@@ -25,7 +25,7 @@ class LoginResponseDTO { | |||
return RefreshTokenDTO( | |||
accessToken: accessToken, | |||
refreshToken: refreshToken, | |||
expiresIn: expiresIn, | |||
// expiresIn: expiresIn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments
No description provided.