Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stacked_themes for managing themes. #101

Closed
Thesmader opened this issue Dec 21, 2020 · 0 comments · Fixed by #102
Closed

Use stacked_themes for managing themes. #101

Thesmader opened this issue Dec 21, 2020 · 0 comments · Fixed by #102
Assignees
@Thesmader
Labels
work-in-progress status

Comments

@Thesmader
Copy link
Member

Thesmader commented Dec 21, 2020 •
edited
Loading

Related to #92

Context

The current implementation of the ThemeManager Service is not the best, it doesn't store the preference of the user and doesn't respect the system theme mode. A better solution can be found in a package.

Requirements

The theme management implementation should respect system theme mode and the preference of the user.

Posssible Solutions

The stacked_themes meets the requirements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thesmader Thesmader

Labels
work-in-progress status
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use stacked_themes for theme management. Thesmader/project-elaichi
1 participant
@Thesmader