Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: hamburger in navbar on mobile doesn't show #60

Closed
jessej-samuel opened this issue Oct 11, 2022 · 0 comments
Closed

bug: hamburger in navbar on mobile doesn't show #60

jessej-samuel opened this issue Oct 11, 2022 · 0 comments

Comments

@jessej-samuel
Copy link
Contributor

The button here

dscvitchennai/components/Navbar.js

Line 21 in e81e7ee

<button
is not visible, as color is white inside svg.

Also,

dscvitchennai/components/Navbar.js

Line 61 in e81e7ee

'flex-1 justify-self-center pb-3 mt-8 md:block md:pb-0 md:mt-0 ${navbar ? "block" : "hidden"}'
this line doesn't run due to normal quotations in place of backticks. This makes the whole navbar persist on mobile screens too.

Currently the screen looks like this:
image

It should look like:
image
@jessej-samuel jessej-samuel mentioned this issue Oct 11, 2022
Merged
13 tasks
Arjun31415 added a commit that referenced this issue Oct 11, 2022
@Arjun31415
Merge pull request #61 from jessej-samuel/dev
86fcdb8 
Closes #60: Fix Nav 🍔 on mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessej-samuel