Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade actix-rt to 2.x #46

Closed
dsietz opened this issue Nov 24, 2021 · 4 comments
Closed

Upgrade actix-rt to 2.x #46

dsietz opened this issue Nov 24, 2021 · 4 comments
Assignees
@dsietz
Labels
enhancement New feature or request

Comments

@dsietz
Copy link
Owner

dsietz commented Nov 24, 2021

currently using ~1
@dsietz
Copy link
Owner Author

dsietz commented Nov 24, 2021

This crate is a dev dependency and used for testing. Upgrading it to ^2 will fail the following test.

---- dua::middleware::actix::tests::test_dua_valid_high_ok stdout ----
thread 'dua::middleware::actix::tests::test_dua_valid_high_ok' panicked at 'Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.

@dsietz
Copy link
Owner Author

dsietz commented Nov 24, 2021

The issue is the actix-web used actix-rt ^1.1.1 which uses an older Tokio version.

@dsietz
Copy link
Owner Author

dsietz commented Nov 24, 2021

Currently actix-web 4 is beta.

@dsietz dsietz added the enhancement New feature or request label Nov 24, 2021
@dsietz dsietz self-assigned this Jul 28, 2022
@dsietz
Copy link
Owner Author

dsietz commented Aug 18, 2023

It has been decided to remove the extractor and middleware functionality form the DTC and DUA features, therefore making this issue NA.

dsietz added a commit that referenced this issue Aug 18, 2023
@dsietz
#45 #46 #49
4c5621c
@dsietz dsietz closed this as completed Aug 26, 2023
@dsietz dsietz mentioned this issue Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsietz dsietz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsietz