Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column escape in args (#47) #48

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Conversation

gluck
Copy link
Contributor

@gluck gluck commented Jun 24, 2020

  • use same char escapes as npm (see npm completion output)
  • avoid COMP_WORDBREAKS override

- use same char escapes as npm (see `npm completion` output)
- avoid COMP_WORDBREAKS override
@gluck
Copy link
Contributor Author

gluck commented Jun 24, 2020

(tested on ubuntu)

@dsifford
Copy link
Owner

@dkarlovi can you confirm this resolves your issue on macos?

@dkarlovi
Copy link

@dsifford I can confirm this works for me, it even doesn't inline the backslash the way mvn does in #47 so it's seamless. Great job @gluck, thank you for working on this!

I'm not on OSX though, I'm on Fedora.

@dsifford
Copy link
Owner

Would love to get someone who has access to OSX to confirm this still works for them because that was the specific pain point when I initially wrote the completions.

Once that happens, I'd be happy to merge this in.

@dkarlovi
Copy link

I've asked a few OSX people and it seems Apple doesn't ship Bash 4+ because of GPL 3. They either use zsh or Bash 3.

@dsifford
Copy link
Owner

Yeah, apple is locked in at bash 3. But you can still use homebrew to install modern bash and bash completions.

Those are the demographic I'd like to hear about if possible.

@dsifford
Copy link
Owner

Oh whoops. Forgot that I have tests for macOS already running (and passing) on this PR.

Cool, let's merge this. Thanks @gluck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants