-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create a Build task for DsCOM #102
feat: Create a Build task for DsCOM #102
Conversation
a8b2730
to
45b5f00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Carsten,
as discussed the following change requests:
- docs should be removed
- docs/dscom.build/ReadMe.md should be moved to src/dscom.build/docs/README.md
- the content of src/dscom.build/ReadMe.md should be moved to README.md
Thx, Great work!
I appreciate your feedback. I have submitted e36ea67 and 04afc4b containing the requested changes. |
Entries that are part of Directory.Build.props are removed from csproj. This was requested by @SOsterbrink in dspace-group#102.
The project shall be used to create an MsBuild target for the automated export of Type Libraries.
MsBuild fails to host dSPACE.Runtime.InteropServices for TLB Export
Use the dependency property instead of AfterTargets declaration.
The dscom build documentation is in a reviewable format. Should do as a first draft.
As requested by @marklechtermann the user documentation has been moved to the common section.
As requested by @marklechtermann and @SOsterbrink the documentation folder with the unmaintained documentation was removed while the documentation of the build task was moved to the src folder
Entries that are part of Directory.Build.props are removed from csproj. This was requested by @SOsterbrink in dspace-group#102.
fdb17a3
to
a77b8c3
Compare
Mentioned commits have changed. As requested by @marklechtermann I have rebased the branch onto the latest upstream main branch. Content still stays the same. The recent three commits should contain the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added a few questions to better understand your work.
Thanks for your work and your attention to detail.
The links have been updated to match the new location. The document now contains one sentence per line as requested by @SOsterbrink
5f64d7b
to
9888d9e
Compare
Preface
DsCom is cool, but it lacks support for build within msbuild.
Details
This pull requests adds a nuget package that cares about exporting the Assembly to a type library automatically.
Do to a limitation in msbuild, it is not properly possible to load dependent assemblies in build task.
As suggested by Nate McMaster the task is now bundled in two ways (cf. src\dscom.build\DsComPackaging.targets ):
Features
WarningsAsError
(DSCOM001
)Quality Assurance
Continuous Integraion
Documentation
Known Limitations
NU1701
for this package, if the Assembly targets .NET Standard 2.0 (cf. OutProc Example). A bug must be filed. @carstencodes Severity: MajorContained fixes
Review