Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have more model group IDs under each rule as results #343

Closed
tweddielin opened this issue Dec 18, 2017 · 1 comment
Closed

Have more model group IDs under each rule as results #343

tweddielin opened this issue Dec 18, 2017 · 1 comment
Labels
audition

Comments

@tweddielin
Copy link
Contributor

Right now the result looks like this.

{'best_average_value_precision@_100_abs': 234,
 'best_avg_recency_weight_precision@_100_abs_1.5_linear': 234,
 'best_avg_recency_weight_precision@_100_abs_2.0_linear': 234,
 'best_avg_recency_weight_precision@_100_abs_5.0_linear': 234,
 'best_current_value_precision@_100_abs': 312,
 'most_frequent_best_dist_precision@_100_abs_0.01': 287,
 'most_frequent_best_dist_precision@_100_abs_0.05': 234,
 'most_frequent_best_dist_precision@_100_abs_0.1': 318,
 'most_frequent_best_dist_precision@_100_abs_0.15': 301,
 'random_model_group': 281}

It only has one result model group id for each rule. It would be more useful if we can have more (5, 10?) model group ids in each rule and then we can see what the overlapped model group ids are among different rules.
thcrock pushed a commit that referenced this issue Jan 19, 2018
@tweddielin @thcrock
rule generator + multiple output models [Resolved #355 #346 #343] (#362)
92d8f2b 
- Add .gitignore
- Wrap those queries that specify model groups in the beginning with a function [Resolves #344]
- Make update_metric_filters accept separate arguments and new_filters, [Resolves #345]
- Add rules_maker module [Solves #346]
- Output n models (not just 1) for each rule
- Bring tutorial notebook up to date
@thcrock
Copy link
Contributor

thcrock commented Jan 20, 2018

Closed in #362

@thcrock thcrock closed this as completed Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thcrock @tweddielin