Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for thresholding bug #71

Closed
thcrock opened this issue Mar 24, 2017 · 0 comments
Closed

Test for thresholding bug #71

thcrock opened this issue Mar 24, 2017 · 0 comments
Assignees
@thcrock
Milestone
v0.4

Comments

@thcrock
Copy link
Contributor

thcrock commented Mar 24, 2017

It's possible that the code in ModelScorer has a bug with thresholding, where entities with the same prediction value both above and below the thresholding line, the ones above will not be included in the threshold and thus any metrics based on that threshold may be inflated.

Write a test for this specifically (and fix a bug if it's there).
@thcrock thcrock self-assigned this Mar 24, 2017
@thcrock thcrock added the bug label Mar 24, 2017
thcrock added a commit that referenced this issue Mar 24, 2017
@thcrock
Thresholding unit test [Resolves #71]
31145d6
@thcrock thcrock added this to the v0.4 milestone Apr 11, 2017
thcrock added a commit that referenced this issue Apr 11, 2017
@thcrock
Thresholding unit test [Resolves #71]
9b641f2
@thcrock thcrock added correctness and removed bug labels Apr 11, 2017
jtwalsh0 pushed a commit that referenced this issue Apr 14, 2017
Merge pull request #72 from dssg/thresholding_test
547b13b 
Thresholding unit test [Resolves #71]
jesteria pushed a commit that referenced this issue Nov 28, 2017
@pyup-bot @mbauman
Update psycopg2 from 2.7 to 2.7.1 (#71)
23361d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thcrock thcrock

Labels
None yet
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
1 participant
@thcrock