Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelEvaluator has calls to outdated methods #734

Closed
hemanklamba opened this issue May 5, 2020 · 1 comment · Fixed by #747
Closed

ModelEvaluator has calls to outdated methods #734

hemanklamba opened this issue May 5, 2020 · 1 comment · Fixed by #747
Assignees

Comments

@hemanklamba
Copy link

hemanklamba commented May 5, 2020

l_t[0].plot_score_distribution(figsize=params.figsize)

returns

AttributeError with the following message:
AttributeError: 'Rectangle' object has no property 'normed'

On more digging, it seems that "normed" property has been deprecated and needs to be replaced.

@nanounanue
Copy link
Contributor

Culprit line:

plt.hist(df_.score,
bins=nbins,
normed=True,
alpha=0.5,
color='blue')

From the docs:

normed : bool, optional

    Deprecated; use the density keyword argument instead.

@thcrock thcrock mentioned this issue May 28, 2020
@nanounanue nanounanue self-assigned this May 28, 2020
shaycrk pushed a commit that referenced this issue May 29, 2020
* normed -> density

* Bumped versions of PyYAML and codecov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants