Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to outcome_date #84

Closed
thcrock opened this issue Mar 31, 2017 · 0 comments
Closed

Switch back to outcome_date #84

thcrock opened this issue Mar 31, 2017 · 0 comments
Assignees
@thcrock
Milestone
v0.3

Comments

@thcrock
Copy link
Contributor

thcrock commented Mar 31, 2017

When generating labels, we currently look for a 'date' column but this is wrong. Use outcome_date, to match the yaml comments
@thcrock thcrock added the bug label Mar 31, 2017
thcrock added a commit that referenced this issue Mar 31, 2017
@thcrock
Have BinaryLabelGenerator look for outcome_date [Resolves #84]
ad1ba78
thcrock added a commit that referenced this issue Mar 31, 2017
@thcrock
Have BinaryLabelGenerator look for outcome_date [Resolves #84]
9ab1678
@thcrock thcrock self-assigned this Mar 31, 2017
@thcrock thcrock added this to the v0.3 milestone Apr 5, 2017
@k1aus k1aus closed this as completed in 85b2fe5 Apr 6, 2017
k1aus added a commit that referenced this issue Apr 6, 2017
@k1aus
Merge pull request #86 from dssg/outcome_date
51aab7f 
Have BinaryLabelGenerator look for outcome_date [Resolves #84]
jesteria pushed a commit that referenced this issue Nov 28, 2017
@mbauman
Merge pull request #84 from dssg/mb/82
2d97d5a 
Don't modify dict during iteration when shortening keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thcrock thcrock

Labels
None yet
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@thcrock