Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Categorical Choices [Resolves #33] #46

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Dynamic Categorical Choices [Resolves #33] #46

merged 1 commit into from
Mar 28, 2017

Conversation

thcrock
Copy link
Contributor

@thcrock thcrock commented Mar 16, 2017

  • Add new feature categorical option, 'choice_query', which runs a query to determine a list of Collate choices
  • Cache results of choice query in FeatureGenerator
  • Add example of dynamic categorical to example_experiment_config.yaml

@codecov-io
Copy link

codecov-io commented Mar 16, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@31044c8). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master     #46   +/-   ##
========================================
  Coverage          ?   88.4%           
========================================
  Files             ?      15           
  Lines             ?     707           
  Branches          ?       0           
========================================
  Hits              ?     625           
  Misses            ?      82           
  Partials          ?       0
Impacted Files Coverage Δ
triage/feature_generators.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31044c8...7097ae8. Read the comment docs.

@thcrock
Dynamic Categorical Choices [Resolves #33]
82fe5eb 
- Add new feature categorical option, 'choice_query', which runs a query to determine a list of Collate `choices`
- Cache results of choice query in FeatureGenerator
- Add example of dynamic categorical to example_experiment_config.yaml
ecsalomon
ecsalomon reviewed Mar 28, 2017
View reviewed changes
Copy link
Contributor

@ecsalomon ecsalomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This will make configs much cleaner and easier to maintain. :)

@ecsalomon ecsalomon merged commit 7c2e5d9 into master Mar 28, 2017
@ecsalomon ecsalomon deleted the dynamic_categoricals branch March 28, 2017 21:31
jesteria pushed a commit that referenced this pull request Nov 28, 2017
@pyup-bot @mbauman
Update coverage from 4.2 to 4.3.1 (#46)
f528951
jesteria pushed a commit that referenced this pull request Nov 29, 2017
@ecsalomon
Merge pull request #46 from dssg/replace_or_use
270fa64 
Allow Architect to skip building matrix if it exists [Resolves #45]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecsalomon ecsalomon ecsalomon left review comments

Assignees

@jzanzig jzanzig

@k1aus k1aus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thcrock @codecov-io @ecsalomon @jzanzig @k1aus