Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leave-one-in feature group mixer strategy [Resolves #88] #89

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

thcrock
Copy link
Contributor

@thcrock thcrock commented Apr 6, 2017

  • Rename 'all' feature group mixer strategy to the more accurate leave-one-in
  • Create new 'all' feature group mixer strategy that smashes all groups into one feature dictionary
  • Improve message of exception that is thrown when an unknown strategy is given
  • Beef up docstrings

- Rename 'all' feature group mixer strategy to the more accurate leave-one-in
- Create new 'all' feature group mixer strategy that smashes all groups into one feature dictionary
- Improve message of exception that is thrown when an unknown strategy is given
- Beef up docstrings
@codecov-io
Copy link

codecov-io commented Apr 6, 2017

Codecov Report

Merging #89 into master will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   89.74%   89.72%   -0.02%     
==========================================
  Files          22       22              
  Lines         946      954       +8     
==========================================
+ Hits          849      856       +7     
- Misses         97       98       +1
Impacted Files Coverage Δ
triage/feature_group_creator.py 92.85% <ø> (ø) ⬆️
triage/feature_group_mixer.py 96.55% <88.88%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259af31...fdd0c66. Read the comment docs.

@thcrock thcrock merged commit 8ef1194 into master Apr 6, 2017
@thcrock thcrock deleted the leave-one-in branch April 6, 2017 23:46
jesteria pushed a commit that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants