Remove postgres service from github action [Resolves #899] #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`testing.postgresql` runs `initdb` locally. The postgres service doesn't get used.
jtwalsh0
added
the
trivial
thcrock
approved these changes
Jun 9, 2022
|
Thanks @jtwalsh0! @nanounanue and @kasunamare -- how (if it all) does this interact with the work you've been doing to upgrade sqlalchemy and friends? Seems like if it goes unused there shouldn't be an issue, but I just wanted to run it by both of you before merging anything to be sure! |
rayidghani
deleted the
remove-postgres-service-from-github-test-runner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing.postgresqlrunsinitdblocally. The postgres service doesn't get used.