Implement creating OCI resources #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables dstack to automatically create OCI compartments and network resources on server launch. This is part of the OCI backend implementation. Behind the OCI_BACKEND feature flag.
r4victor
reviewed
May 27, 2024
r4victor
approved these changes
May 27, 2024
|
@r4victor, compartment_id is optional in all models, but required in OCIStoredConfig. If it is missing, a default |
|
Oh, maybe I misunderstood the question. If you were asking what would happen if you specify a nonexistent comparment_id in server config — the configurator will hang for about 3 minutes and then fail with an error message here. Unfortunately, I could not find a way to distinguish a nonexistent compartment from a compartment being created, so this wait is required, but specifying a wrong compartment_id should be a rare case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables dstack to automatically create OCI compartments and network resources on server launch. This is part of the OCI backend implementation (#1194). Behind the OCI_BACKEND feature flag.