Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore cache functionality #527

Merged
merged 11 commits into from
Jun 29, 2023
Merged

Restore cache functionality #527

merged 11 commits into from
Jun 29, 2023

Conversation

Egor-S
Copy link
Contributor

@Egor-S Egor-S commented Jun 28, 2023 •
edited
Loading

Closes #519, #180

  • Replace workflow_name with configuration_path
  • Change dstack prune cache signature to accept working dir and configuration path
  • Store relative symlinks in artifacts as empty objects with metadata (cloud providers only)
  • Define minimalistic base.Storage interface
  • Implement basic methods on top of the base.Storage interface
  • Implement base.Storage for AzureStorage

TODO

  • Test in the cloud runtime

edit: TODO (next PR)

  • Implement base.Storage interface for all backends' storages
  • Add tests for base.UploadDir

@Egor-S Egor-S merged commit f0b66fb into master Jun 29, 2023
@Egor-S Egor-S deleted the issue_519_cache branch June 29, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4victor r4victor r4victor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make cache work with new YAML configurations
2 participants
@Egor-S @r4victor