-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simpler Kalman squash #110
Conversation
# Conflicts: # stonesoup/predictor/kalman.py # stonesoup/predictor/tests/test_kalman.py # stonesoup/updater/kalman.py
# Conflicts: # stonesoup/updater/base.py
# stonesoup/predictor/kalman.py # stonesoup/predictor/tests/test_kalman.py # stonesoup/updater/kalman.py Conflicts resolved and minor updates to import statements.
…old Kalman get_measurement_prediction() function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minus the failed CircleCI tests.
…g out bits of the test. All traced back to the issue of what the difference between 'internal noise' and 'external noise' in the function function() is. This branch asserts that function(noise=0) is the same as function(). Not so on the main branch at present.
…e issue in .function() call. That left to future discussion.
These now pass... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@jmbarr: Could you please update the documentation strings so they are in NumPy format. |
…cing a keyword (default False) which will force symmtrisation.
…cing a keyword (default False) which will force symmetrisation. (Updated name of flag.)
Done; now compliant, as far as I can see. Just chasing the last Flake8 errors... |
Supersedes the now outdated Simpler Kalman pull request.