Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler Kalman squash #110

Closed
wants to merge 19 commits into from
Closed

Simpler Kalman squash #110

wants to merge 19 commits into from

Conversation

jmbarr
Copy link
Contributor

@jmbarr jmbarr commented May 29, 2019

Supersedes the now outdated Simpler Kalman pull request.

# Conflicts:
#	stonesoup/predictor/kalman.py
#	stonesoup/predictor/tests/test_kalman.py
#	stonesoup/updater/kalman.py
# Conflicts:
#	stonesoup/updater/base.py
#	stonesoup/predictor/kalman.py
#	stonesoup/predictor/tests/test_kalman.py
#	stonesoup/updater/kalman.py

Conflicts resolved and minor updates to import statements.
@jmbarr jmbarr changed the title Simpler kalman squash Simpler Kalman squash May 29, 2019
…old Kalman get_measurement_prediction() function.
Copy link
Contributor

@dlast-dstl dlast-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minus the failed CircleCI tests.

…g out bits of the test. All traced back to the issue of what the difference between 'internal noise' and 'external noise' in the function function() is. This branch asserts that function(noise=0) is the same as function(). Not so on the main branch at present.
…e issue in .function() call. That left to future discussion.
@jmbarr
Copy link
Contributor Author

jmbarr commented Jun 7, 2019

Looks good, minus the failed CircleCI tests.

These now pass...

Copy link
Contributor

@dlast-dstl dlast-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sdhiscocks
Copy link
Member

@jmbarr: Could you please update the documentation strings so they are in NumPy format.

stonesoup/models/base.py Show resolved Hide resolved
stonesoup/models/measurement/linear.py Outdated Show resolved Hide resolved
stonesoup/models/transition/nonlinear.py Outdated Show resolved Hide resolved
stonesoup/predictor/tests/test_kalman.py Outdated Show resolved Hide resolved
stonesoup/updater/kalman.py Outdated Show resolved Hide resolved
@jmbarr
Copy link
Contributor Author

jmbarr commented Jul 17, 2019

@jmbarr: Could you please update the documentation strings so they are in NumPy format.

Done; now compliant, as far as I can see. Just chasing the last Flake8 errors...

@sdhiscocks sdhiscocks added this to the Beta Release 2 milestone Jul 23, 2019
@sdhiscocks sdhiscocks deleted the SImplerKalmanSquash branch June 12, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants