-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change StateVector indexing #187
Conversation
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 111 111
Lines 3793 3794 +1
Branches 548 549 +1
=======================================
+ Hits 3486 3487 +1
Misses 225 225
Partials 82 82
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work with types which aren't int
but could usefully be returned directly (e.g. float
, long
, angle
, myOwnVerySpecialType
, etc)?
Doesn't this PR have much the same intent as #170? Would it be worth combining? |
This works the same regardless of the type |
…ted' and update code/tests to match
f8d1e21
to
7b903a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit the code does look much cleaner with this change.
This pull request updates StateVector indexing and code that uses it to demonstrate the change suggested in issue #186. I think this is a simple and useful update, but if people feel this over-complicates the Statevector class for little benefit, then the PR can be shelved.