Minor Addition and Changes to MultiMeasurementInitiator #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gawebb-dstl
requested review from
nperree-dstl and
rcgorman-dstl
and removed request for
a team
|
The docs are failing to build docs/demos/Video_Processing.py ModuleNotFoundError: No module named 'pytube' I don't think this is related to any of my changes |
sdhiscocks
reviewed
Sep 1, 2023
Added property `skip_non_reversible` to MultiMeasurementInitiator
gawebb-dstl
force-pushed
the
NoHistoryMultiMeasurementInitiator
branch
from
5ac9c9c
to
540b96e
Compare
|
I messed up the rebase so the branch history got messy. Instead I’ve recreated the branch. Hopefully it is a lot simpler now. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
+ Coverage 93.77% 93.79% +0.02%
==========================================
Files 190 190
Lines 11655 11662 +7
Branches 2412 2415 +3
==========================================
+ Hits 10929 10938 +9
+ Misses 497 495 -2
Partials 229 229
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sdhiscocks
approved these changes
Oct 17, 2023
nperree-dstl
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoHistoryMultiMeasurementInitiatorwas created so track metrics wouldn’t take into account the part of the track that was in ‘holding’. ‘Holding’ tracks aren’t available to the tracker. When a holding track is upgraded to a full/sure track it takes its history with it. When assessing tracks post-simulation with metrics the full history is used which can be misrepresentative.An option was added to skip measurements that don’t have a
ReversibleModelmeasurement model inMultiMeasurementInitiator