Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toJSON should deep copy #11

Closed
kgryte opened this issue Dec 3, 2015 · 0 comments · Fixed by #12
Closed

toJSON should deep copy #11

kgryte opened this issue Dec 3, 2015 · 0 comments · Fixed by #12
Assignees
@kgryte
Labels
bug

Comments

@kgryte
Copy link
Contributor

kgryte commented Dec 3, 2015

Currently, shape and strides are shallow copied. This is leaky and may lead to bugs due to (unintended) mutations.

The following modules should be used:

  1. dstructs-cast-arrays to cast the internal typed array to a generic array
  2. utils-copy to copy shape and strides
@kgryte kgryte added the bug label Dec 3, 2015
@kgryte kgryte mentioned this issue Dec 4, 2015
Merged
@kgryte kgryte self-assigned this Dec 4, 2015
@kgryte kgryte closed this as completed in #12 Dec 4, 2015
kgryte added a commit that referenced this issue Dec 4, 2015
@kgryte
Merge pull request #12 from dstructs/develop
01ba69c 
Resolve #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgryte kgryte

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #11 dstructs/matrix
1 participant
@kgryte