Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve https://github.com/dswah/pyGAM/issues/301 #302

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jonathan-taylor
Copy link

  • Instead of filling with zeros in _flatten_mesh and generate_X_grid create an X matrix with constant rows given by the midpoint of the edge_knots so they values will be valid.
    -Also centered output of partial_dependence as the Y-axis is meaningless.

Copy link

@5ch0r5ch1 5ch0r5ch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@dswah
Copy link
Owner

dswah commented Feb 8, 2024

thanks for this!!
im updating master to use the latest build dependencies...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants