Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the behavior when execution date is Sunday #21

Merged
merged 2 commits into from
Oct 22, 2017
Merged

Conversation

dtan4
Copy link
Owner

@dtan4 dtan4 commented Oct 22, 2017

If Xronor is executed at Sunday, generated result is difference from the expected one.

@codecov-io
Copy link

codecov-io commented Oct 22, 2017

Codecov Report

Merging #21 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #21     +/-   ##
=========================================
+ Coverage    96.4%   96.71%   +0.3%     
=========================================
  Files          31       31             
  Lines         891      912     +21     
=========================================
+ Hits          859      882     +23     
+ Misses         32       30      -2
Impacted Files Coverage Δ
spec/lib/xronor/dsl/schedule_converter_spec.rb 100% <100%> (ø) ⬆️
lib/xronor/dsl/schedule_converter.rb 100% <100%> (+1.51%) ⬆️
spec/lib/xronor/parser_spec.rb 100% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a250b1...deb87a2. Read the comment docs.

@dtan4 dtan4 merged commit 3b36b43 into master Oct 22, 2017
@dtan4 dtan4 deleted the fix-broken-test branch October 22, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants