Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom env and revision #7

Closed
wants to merge 2 commits into from
Closed

Custom env and revision #7

wants to merge 2 commits into from

Conversation

znz
Copy link
Contributor

@znz znz commented Jun 30, 2014

Heroku's staging has production env.
And I want to use this in such staging env.
see https://devcenter.heroku.com/articles/multiple-environments

How to use:

    # Enable rack-dev-mark
    config.rack_dev_mark.enable = !Rails.env.production? || ENV['RACK_DEV_MARK']
    # Customize themes if you want to do so
    config.rack_dev_mark.theme = [:title, Rack::DevMark::Theme::GithubForkRibbon.new(position: 'left-bottom', color: 'black', env: ENV['RACK_DEV_MARK'])]

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 7b94ff3 on znz:patch-1 into eadf7bc on dtaniwaki:master.

@dtaniwaki
Copy link
Owner

Hi @znz ,

Thanks for your pull request. I'd rather set the environment variable because other themes want to do the same thing but don't want to implement it individually.

Please take a look of this change.
6fe735c

Your suggestion helped me to improve the gem. Thanks a lot!

@dtaniwaki
Copy link
Owner

I released rack-dev-mark 0.4.6 just now. Please try it and tell me if it solves your problem.

@znz
Copy link
Contributor Author

znz commented Jun 30, 2014

Thanks you more smart way.
I satisfied with the improvement!

@znz znz closed this Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants