Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine log messages when verifying probabilities. #1502

Closed
20 tasks done
JohnHalleyGotway opened this issue Sep 28, 2020 · 1 comment · Fixed by #1503
Closed
20 tasks done

Refine log messages when verifying probabilities. #1502

JohnHalleyGotway opened this issue Sep 28, 2020 · 1 comment · Fixed by #1503
Assignees
Labels
MET: Library Code MET: Probability Verification priority: medium Medium Priority requestor: NOAA/WPC NOAA Weather Prediction Center type: task An actionable item of work
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Sep 28, 2020

Describe the Task

This issue consists of 2 tasks:

Task 1:
As described in met-help (https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=96813), clarify the log messages when no climatology bins have been defined.
Existing log message:

DEBUG 4: parse_conf_climo_cdf() -> For "cdf_bins" (1) and "center_bins" (false), defined climatology CDF thresholds: >=0.00000,>=1.00000

New log message:

DEBUG 4: parse_conf_climo_cdf() -> Since "cdf_bins" = 1, no climatology bins will be applied.

Task 2:
The "prob" config file entry can either be specified as a dictionary (when parsing NOAA GRIB files) or as a boolean (for other probability data). Both types are supported and fine. However, when specified as a boolean, met-9.1 prints the following warning message:

WARNING: Dictionary::lookup_dictionary() -> dictionary lookup failed for name "prob"

Modify the code to suppress this warning message since it only causes confusion.

Time Estimate

1 hour.

Sub-Issues

Consider breaking the task down into sub-issues.
None required.

Relevant Deadlines

None.

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added component: library code type: task An actionable item of work priority: medium Medium Priority labels Sep 28, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.0 milestone Sep 28, 2020
@JohnHalleyGotway JohnHalleyGotway changed the title Clarify log message about the definition of climatological bins. Refine log messages when verifying probabilities. Sep 28, 2020
JohnHalleyGotway added a commit that referenced this issue Sep 28, 2020
…() when no climo CDF bins have been requested.
JohnHalleyGotway added a commit that referenced this issue Sep 28, 2020
…is defined as a boolean instead of as a dictionary.
@JohnHalleyGotway
Copy link
Collaborator Author

Tested by running one of the Grid-Stat commands executed by running "make test".
With met-9.1:

cd met/scripts
export TEST_OUT_DIR=../out 
../bin/grid_stat ../data/sample_fcst/2005080312/pop5km_2005080312F096.grib_G212    ../out/pcp_combine/sample_obs_2005080800V_12A.nc    config/GridStatConfig_POP_12    -outdir ../out/grid_stat -v 4

The log messages include:

WARNING: 
WARNING: Dictionary::lookup_dictionary() -> dictionary lookup failed for name "prob"
WARNING: 
DEBUG 4: parse_conf_climo_cdf() -> For "cdf_bins" (1) and "center_bins" (false), defined climatology CDF thresholds: >=0.00000,>=1.00000

After compiling this change and rerunning, the log messages are now:

DEBUG 4: parse_conf_climo_cdf() -> Since "cdf_bins" = 1, no climatology CDF bins will be applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Library Code MET: Probability Verification priority: medium Medium Priority requestor: NOAA/WPC NOAA Weather Prediction Center type: task An actionable item of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants