Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2180 main_v10.1 kft #2182

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Jun 13, 2022

Please see PR #2181 for the develop branch and review this one at the same time.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Manually ran plot_data_plane setting the convert function for a few of these to confirm they work as expected.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Review the new derivation functions for accuracy.

  • Confirm that all the GitHub actions run without error and you see a green checkmark to indicate success (not a red X to indicate failure).

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
    None needed.

  • Do these changes include sufficient testing updates? [No]
    None needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Tues 6/14].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.3 (bugfix) milestone Jun 13, 2022
@JohnHalleyGotway JohnHalleyGotway linked an issue Jun 13, 2022 that may be closed by this pull request
20 tasks
Copy link

@LoganDawson-NOAA LoganDawson-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks have been passed, and all equations add to the ConfigConstants file are correct. PR approved as is.

Copy link

@LoganDawson-NOAA LoganDawson-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks have been passed, and all equations add to the ConfigConstants file are correct. PR approved as is.

@JohnHalleyGotway JohnHalleyGotway merged commit 679780e into main_v10.1 Jun 14, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2180_main_v10.1_kft branch June 14, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add M_to_KFT and KM_to_KFT functions to ConfigConstants.
2 participants