Bugfix 2370 mainv10.1 - 6 line headers and yyyy-MMM #2396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GHA to run for this new main_v10.1-ref branch.
…, reproducible on seneca. Just initialize the newly allocated time_values array with values of -10. PLEASE REMOVE THAT TEST CODE PRIOR TO SUBMITTING A PR TO FIX THIS ISSUE.
…lid_time Bugfix 2123 main v10.1 nccf valid time
…gth_array Bugfix dtcenter/METplus-Internal#14 main_v10.1 fixed length array
* Per #2162, update versions and notes for the 10.1.2 bugfix release * Per #2162, update versions and notes for the 10.1.2 bugfix release * Per #2162, fixing syntax error * Add "METplus-Internal" before the issue number for clarity Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu>
* added logic to manually trigger a workflow via the GitHub… (#2107) * Bugfix #2102 main_v10.1 initialize modified_hdr_typ (#2108) * Bugfix #2115 main_v10.1 Rotated LatLon (#2116) * Per #2123, added debug code to make this error that was unrepoducible, reproducible on seneca. Just initialize the newly allocated time_values array with values of -10. PLEASE REMOVE THAT TEST CODE PRIOR TO SUBMITTING A PR TO FIX THIS ISSUE. * #2123 Initialize ValidTime if afile to read time bvariable * #2123 Support int64 data type * #2123 Support int64 data type * Bugfix #2118 main_v10.1 grib1_rotll (#2129) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Bugfix #2106 main_v10.1 gcc (#2134) * Feature 2141 v10.1.1 (#2144) * Add testing and docs badges. * #14 Using literal instead of numbers and make sure no overflow * #14 Using literal instead of numbers * #14 Added tmp_buf_size * #14 Define n_kw_infos first * #14 Using literal instead of numbers * Bugfix #2148 main_v10.1 misses (#2149) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * dtcenter/METplus-Internal#14 formatting code * Feature 2162 v10.1.2 (#2163) * Per #2162, update versions and notes for the 10.1.2 bugfix release * Per #2162, update versions and notes for the 10.1.2 bugfix release * Per #2162, fixing syntax error * Add "METplus-Internal" before the issue number for clarity Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
…e_stat_missing_members Bugfix #2208 main_v10.1 ensemble_stat with missing members
…r image that it used in the METplus automated tests
…CNT line type table for the RMSOA, ANOM_CORR_UNCNTR, and SI statistics.
… Checking inputs at angstrom_power_interplation
|
Wrong target branch |
This was
linked to
issues
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
#2370:
AERONET V3 input files with the 7 lines header were supported before. The fix is to support 6 lines header (without site_name at line 2). The concatenation of multiple AERONET V3 files should be 6 lines header (can be done by deleting line 2 if 7 lines header).
sanity checking: the site_name at the line 2 and the site_name at the first data column should match.
#2383: Avoid AOD 550 calculation if any inputs are negative.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Tested with the sample files at /d1/personal/hsoh/data/discussions/discussions_1888
/d1/personal/hsoh/data/discussions/discussions_1888/GSFC_20221202.lev15.txt: contains just one site with 6 lines header
/d1/personal/hsoh/data/discussions/discussions_1888/20221202.lev15.org.txt: contains multiple sites with 6 lines header
/d1/personal/hsoh/data/discussions/discussions_1888/20221202.lev15.txt: reduced from 20221202.lev15.org.txt for unittest
test with other 6 line herder inputs
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes