Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 345 develop gha node20 #347

Merged
merged 20 commits into from
Feb 2, 2024
Merged

Feature 345 develop gha node20 #347

merged 20 commits into from
Feb 2, 2024

Conversation

lisagoodrich
Copy link
Contributor

@lisagoodrich lisagoodrich commented Jan 26, 2024 •
edited
Loading

Pull Request Testing

  • Describe testing already performed for these changes:

    I ran the commands John HG listed in the issue

Command to make sure old stuff isn’t there:
Old:
grep checkout@v3 *
grep artifact@v3 *
grep setup-python@v4%g *
grep github-script@v6%actions *

New:
grep checkout@v4 *
grep artifact@v4 *
grep setup-python@v5%g *
grep github-script@v7%actions *

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    I am unable to complete manual testing with the workflow dispatch option for this component. Please test to make sure this is working as needed.
    Please check "Milestone". I'm not sure I picked the right one.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [INo]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [1/31/24].
    >

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

hankenstein2 and others added 19 commits July 28, 2023 12:56
@hankenstein2
Prepare for next release
10ce04c
@georgemccabe
add missing end quote to fix package install
07343b8
@JohnHalleyGotway
Merge pull request #320 from dtcenter/georgemccabe-patch-1
227b264
@TatianaBurek
reset_index is performed on the float value #322 (#323)
3baae11
@hankenstein2
Update release notes (#328)
f794110
@jprestop
Update release-notes.rst formatting
7185ec3
@jprestop
Update and rename 2.1.0_wcoss2 to 3.0.0_wcoss2
83050f1
@TatianaBurek
loop over statistics only once to avoid data multiplication #330 (#331)
cf3dbd4
@jprestop
Added sphinx_rtd_theme to extensions
dfd7595
@jprestop
Updated requirements.txt
7c6f14a
@jprestop
Added pillow
4b83c74
@lisagoodrich @jprestop
feature 497 headers (#336)
fcf7c3f 
* changing header for continuity

* Modified the other headers in the file to be consistent with other repos

---------

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
@hankenstein2
Beta2 release (#338)
1513c66
@hankenstein2
Next version
8fedf43
@hertneky
Feature 332 di doc (#333)
d7d5871 
* Add difficulty index documentation

* Add more documentation

* Add more definition

* Fix indent

* Add figure

* fix indentation

* fix equations

* Add table

* Added remaining tables

* fix table issue

* Add links

* formatting

* change link to latest

---------

Co-authored-by: Tracy <tracy.hertneky@noaa.gov>
@hankenstein2
Additions to beta2 release (#340)
219613a
@hankenstein2
Next beta
444b336
@bikegeek
Bugfix 329 negative bcmse (#344)
f87fa10 
* Issue #329 return 0 if negative BCMSE value is calculated

* Issue #329 add test for calculate_bcmse() in the sl1l2_statistics module

* Issue #392 added test_sl1l2.py to the list of pytests to run
@lisagoodrich
command line updates
dd4e8ff
@lisagoodrich lisagoodrich added this to the METcalcpy-2.0.3 (bugfix) milestone Jan 26, 2024
jprestop
jprestop approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @lisagoodrich. It looks good to me. I'll approve and squash and merge and check to ensure the warning goes away.

@jprestop jprestop merged commit 15d1cc0 into main_v2.1 Feb 2, 2024
6 checks passed
@JohnHalleyGotway JohnHalleyGotway linked an issue Feb 2, 2024 that may be closed by this pull request
Update GitHub actions workflows to switch from node 16 to node 20 #345
Closed
21 tasks
jprestop added a commit that referenced this pull request Feb 2, 2024
@jprestop
Revert "Feature 345 develop gha node20 (#347)"
b585670 
This reverts commit 15d1cc0.
This was referenced Feb 2, 2024
Merged
Merged
jprestop added a commit that referenced this pull request Feb 2, 2024
@jprestop
Revert "Feature 345 develop gha node20 (#347)" (#350)
b359855 
This reverts commit 15d1cc0.
@jprestop jprestop deleted the feature_345_develop_gha_node20 branch February 2, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprestop jprestop jprestop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
METplus-Analysis-6.0.0 Development
Status: 🏁 Done
Milestone
METcalcpy-3.0.0
Development

Successfully merging this pull request may close these issues.

Update GitHub actions workflows to switch from node 16 to node 20
8 participants
@lisagoodrich @jprestop @hankenstein2 @georgemccabe @JohnHalleyGotway @TatianaBurek @hertneky @bikegeek