Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 273 python requirements #276

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

lisagoodrich
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

    Added a literalinclude
    Added a Python Requirements section under "Requirements"
    Added This note, "The requirements below come directly from the requirements.txt file at the top level of the repository."

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please read the documentation carefully and make sure this is what we want.
    https://github.com/dtcenter/METdataio/blob/feature_273_python_requirements/docs/Users_Guide/installation.rst

I didn't remove this sentence, "METdataio also requires the Python packages pymysql, pandas, numpy, pyyaml, and lxml."
Please note, I couldn't find "pymysql" in the requirements.txt. Should this be removed?

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [2/15/24].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@lisagoodrich lisagoodrich added this to the METdataio-3.0.0 milestone Feb 6, 2024
@jprestop jprestop linked an issue Feb 7, 2024 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @lisagoodrich. I approve this request. I'll go ahead and squash and merge.

@jprestop jprestop merged commit d276b49 into develop Feb 28, 2024
9 checks passed
@jprestop jprestop deleted the feature_273_python_requirements branch February 28, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Modify Requirements section of the User's Guide
2 participants