Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Added a
literalinclude
Added a Python Requirements section under "Requirements"
Added This note, "The requirements below come directly from the requirements.txt file at the top level of the repository."
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please read the documentation carefully and make sure this is what we want.
https://github.com/dtcenter/METdataio/blob/feature_273_python_requirements/docs/Users_Guide/installation.rst
I didn't remove this sentence, "METdataio also requires the Python packages pymysql, pandas, numpy, pyyaml, and lxml."
Please note, I couldn't find "pymysql" in the requirements.txt. Should this be removed?
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [2/15/24].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes