Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to using Python 3.10.4 #310

Closed
7 of 22 tasks
lisagoodrich opened this issue Jan 24, 2023 · 1 comment
Closed
7 of 22 tasks

Upgrade to using Python 3.10.4 #310

lisagoodrich opened this issue Jan 24, 2023 · 1 comment
Assignees
@bikegeek
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: external dependency External dependency issue priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Milestone
METplotpy-2.1.0

Comments

@lisagoodrich
Copy link
Contributor

lisagoodrich commented Jan 24, 2023 •
edited by bikegeek
Loading

Describe the Task

  • Update any code necessary for upgrading to Python 3.10.4. We are taking this action because WCOSS2 is only allowing Python 3.10.4 to be used for operational installations. Therefore, we need to ensure that our next release uses Python 3.10.4. Update the requirements.txt and nco_requirements.txt files. Create conda environment file to match requirements.txt . Creating an environment_nco.yaml is not necessary (NCO does not use conda to create environments )

  • Verify that netCDF4 is upgraded to 1.6.2 to be consistent with NCO requirements in METcalcpy.

  • Please also update .readthedocs.yaml with 3.10.4 when Python 3.10 support is available.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
(Assignee please fill this in once you know.)

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Incorporate in a beta version as soon as possible to ensure there are no problems.

Funding Source

Please ask Tara before starting on this work.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@lisagoodrich lisagoodrich added type: task An actionable item of work priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: external dependency External dependency issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Jan 24, 2023
@lisagoodrich lisagoodrich added this to the METplotpy-2.1.0 milestone Jan 24, 2023
@lisagoodrich lisagoodrich moved this from 📋 Backlog to 🔖 Ready in METplus-Analysis-5.1.0 Development Jan 24, 2023
@bikegeek
Copy link
Collaborator

bikegeek commented Feb 1, 2023

created a conda environment on 'seneca' /home/met_test/.conda/envs/metplotpy_py310
tested on METplotpy tests and METplus use case for hovmoeller plot

bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
Issue #310. Updating the version of matplotlib no longer allows line …
aba0551 
…width of NA to be set to 0. Set to 0.1 to still allow turning off connecting points
bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
#310 clean up copy and paste from ROC diagram
002b3ec
bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
#310 Initial commit of vulnerability check
3dd7573
bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
#310 newer version of Matplotlib does not support linewidth=0
36d044b
bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
#310 per latest Matplotlib doc, set linewidth=None in line 289 instea…
a215a82 
…d of 0
bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
#310 added issue branch as trigger to run, and added no-deps to True
f823dd1
bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
#310 request summary at end of action and fix formatting for no-deps
13859df
bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
#310 try using a virtual env and use only local to avoid system packages
6ef471c
bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
#310 remove unused content, explicitly request summary
92a3559
bikegeek added a commit that referenced this issue Feb 2, 2023
@bikegeek
#310 accidentally removed jobs command
2875d78
@bikegeek bikegeek moved this from 🔖 Ready to 🏗 In progress in METplus-Analysis-5.1.0 Development Feb 3, 2023
@bikegeek bikegeek mentioned this issue Feb 14, 2023
Merged
14 tasks
bikegeek added a commit that referenced this issue Feb 24, 2023
@bikegeek
Issue #310 update versions, add eofs and scikit-learn
32db05b
bikegeek added a commit that referenced this issue Feb 24, 2023
@bikegeek
Issue #310 update versions for scipy, and for Non NCO requirement, ad…
932b1fd 
…d eofs and scikit-learn
bikegeek added a commit that referenced this issue Feb 24, 2023
@bikegeek
Issue #310 useful script for running tests to check NCO requirements
8835c1f
bikegeek added a commit that referenced this issue Feb 24, 2023
@bikegeek
Issue #310 remove cartopy
4fff0a6
@bikegeek bikegeek moved this from 🏗 In progress to 👀 In review in METplus-Analysis-5.1.0 Development Feb 25, 2023
bikegeek added a commit that referenced this issue Feb 28, 2023
@bikegeek
Feature 310 python upgrade (#321)
b1985d7 
* Update nco_requirements.txt

updates to version for Python 3.10.4 upgrade

* Update nco_requirements.txt

incorrect bugfix version for plotly, should be 5.13.0

* Update requirements.txt

update versions for Python 3.10.4 upgrade

* Update unit_tests.yaml

update Python version to 3.10

* Update requirements.txt

update opencv-python to 4.7.0+

* Issue #310.  Updating the version of matplotlib no longer allows line width of NA to be set to 0. Set to 0.1 to still allow turning off connecting points

* #310 clean up copy and paste from ROC diagram

* #310 Initial commit of vulnerability check

* attempt to fix syntax error on line 22

* add specific Python version

* #310 newer version of Matplotlib does not support linewidth=0

* #310 per latest Matplotlib doc, set linewidth=None in line 289 instead of 0

* Update requirements.txt

update versions of pint and metpy

* #310 added issue branch as trigger to run, and added no-deps to True

* #310 request summary at end of action and fix formatting for no-deps

* #310 try using a virtual env and use only local to avoid system packages

* #310 remove unused content, explicitly request summary

* #310 accidentally removed jobs command

* Update documentation.yml

update to Python 3.10

* Update .readthedocs.yaml

Python 3.8 is the latest version of Python supported by ReadtheDocs

* Update requirements.txt

alphabetize and update the versions so they are consistent with what is on host 'seneca'

* Update installation.rst

Update versions for Python and other packages

* Delete requirements.txt

use the requirements.txt from the root directory

* Update requirements.txt

pytest in incorrect alphabetical order

* Update nco_requirements.txt

rearrange into alphabetical order

* Update requirements.txt

remove cartopy, this is only used for the fv3 physics tendency plot

* Update requirements.txt

updated netcdf4 version

* Issue #310 update versions, add eofs and scikit-learn

* Issue #310 update versions for scipy, and for Non NCO requirement, add eofs and scikit-learn

* Issue #310 useful script for running tests to check NCO requirements

* Issue #310 remove cartopy
@bikegeek bikegeek moved this from 👀 In review to ✅ Done in METplus-Analysis-5.1.0 Development Feb 28, 2023
@bikegeek bikegeek modified the milestones: METplotpy-2.1.0, METplotpy 2.1.0-beta1 Feb 28, 2023
@JohnHalleyGotway JohnHalleyGotway modified the milestones: METplotpy 2.1.0-beta1, METplotpy-2.1.0 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: external dependency External dependency issue priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Projects
No open projects
METplus-Analysis-5.1.0 Development
Status: ✅ Done
Milestone
METplotpy-2.1.0
Development

No branches or pull requests
3 participants
@bikegeek @JohnHalleyGotway @lisagoodrich