Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox - Keep compatibility with non-WebExtension Browser #42

Closed
typhoon71 opened this issue Jul 7, 2016 · 6 comments
Closed

Firefox - Keep compatibility with non-WebExtension Browser #42

typhoon71 opened this issue Jul 7, 2016 · 6 comments

Comments

@typhoon71
Copy link

typhoon71 commented Jul 7, 2016

If it's possible and not too much work, I suggest to keep compatibility with non-WebExtension "enabled" Browser.
This includes Firefox 47 which is the last stable since Firefox 48 should be out in August(and support WebExtension), and other forks like Palemoon.
I won't ask for Other Chrome derivates because they should already be working (Iron does work).

@dteviot
Copy link
Owner

dteviot commented Jul 7, 2016

@typhoon71
I'm sorry, but I don't understand the request.

Here's the situation.
WebToEpub was originally written as a Chrome extension. (Actually, I first considered making it a Firefox XUL extension, but when I saw the work required to do that I changed my mind and went the Chrome extension route, much less work.)

When I saw that FireFox is able to run Chrome extensions via WebExtensions, I offered the Extension for Firefox. There was one issue were the "download the packed epub" worked on Chrome but not Firefox. Gusser93 provided a fix.

So, to re-iterate. There is only one WebToEpub. To make the Firefox version I literally take the WebToEpub.zip file I send to Google, rename it to "WebToEpub.xpi" and send that to Mozilla. It works because it uses the WebExtensions.

@typhoon71
Copy link
Author

mmmm, what you wrote means that the addon should never have worked on Firefox 47, since WebExtensions aren't supported on it... But I'm pretty sure I was able to use it a couple of times...
Just asking, did something change in the code that downloads the images?
(issue #27, the second image I posted is what I'm referring to)

@dteviot
Copy link
Owner

dteviot commented Jul 7, 2016

@typhoon71
Firefox 47 has some WebExtensions support. It's just not fully implemented.
And I've seen the plug-in do funny things on Firefox 47.
As regards downloading, yes, there were some changes in the released 0.0.0.9, to support user specifying Cover as a URL. Is it still not working on Firefox?

@typhoon71
Copy link
Author

Nope, it's not working on my firefox (47.0.1)
It didn't work on Firefox 48b5 too.
Maybe it works in Aurora? I will try tomorrow.

@typhoon71 typhoon71 reopened this Jul 7, 2016
@typhoon71
Copy link
Author

typhoon71 commented Jul 7, 2016

Awww, wrong button.
Anyway I made an effort and checked with Firefox 49.0a2, and it works.
It'll be a long wait till a stable... (August for the 48)

@typhoon71
Copy link
Author

OK, I did some more testing and found that the plugin seems to have compatibility issues with some firefox addons even on Firefox 49.0a2, but it work with a "pure" profile.
I'll test my addons one by one and report back in a new issue.
I'm closing this one (I didn't know it was born as webextensions addon).

@belldandu belldandu changed the title [Enhanchement] Firefox - Keep compatibility with non-WebExtension Browser Firefox - Keep compatibility with non-WebExtension Browser Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants