Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI build & test for pull requests #22

Closed
bwillard opened this issue Jan 7, 2018 · 4 comments · Fixed by #83
Closed

Set up CI build & test for pull requests #22

bwillard opened this issue Jan 7, 2018 · 4 comments · Fixed by #83
Assignees
@rtannenbaum
Milestone
Stable Infrastruc...

Comments

@bwillard
Copy link
Contributor

bwillard commented Jan 7, 2018

We should ensure that all PRs build and pass tests before submitting.
@bwillard bwillard added this to the Stable Infrastructure milestone Jan 7, 2018
@rtannenbaum
Copy link
Contributor

Brian did an initial investigation, based on that I think we should try the free Travis CI edition to start.

Some notes:

  • Free edition does not require code write access, whereas Paid edition might, due to permissions not being granular enough. (Does require webhook access; Github's API for responding to repo events)
  • Travis supports Node.js whereas others (like Circle) do not. We might need Node.js support for our angular frontend, which has some dependencies on Node even though we don't use it directly
  • Uses a shared worker pool for the rest of the org (google) so we may run into latency problems, but we may move our repo to a different org at some point.

@rtannenbaum
Copy link
Contributor

Travis instructions for java projects. Includes both Maven and Gradle examples. https://docs.travis-ci.com/user/languages/java/

rtannenbaum added a commit that referenced this issue Jan 10, 2018
@rtannenbaum
Create .travis.yml
4b82048 
for #22.

Travis should automatically detect that we use Maven based on the presence of pom.xml.
@rtannenbaum rtannenbaum mentioned this issue Jan 10, 2018
Merged
rtannenbaum added a commit that referenced this issue Jan 10, 2018
@rtannenbaum
Test a bad java change
ec036c7 
to make sure it breaks the Travis build (#22)
@rtannenbaum rtannenbaum mentioned this issue Jan 10, 2018
Closed
rtannenbaum added a commit that referenced this issue Jan 10, 2018
@rtannenbaum
Make Travis notify Slack
d7e0760 
It's configured to notify the #build-status channel

https://portability.slack.com/services/297899893366?updated=1#service_setup

For #22
@rtannenbaum rtannenbaum mentioned this issue Jan 10, 2018
Closed
rtannenbaum added a commit that referenced this issue Jan 11, 2018
@rtannenbaum
Merge pull request #39 from google/travis-slack-2
4d3e570 
Make Travis notify Slack for #22
@rtannenbaum rtannenbaum mentioned this issue Jan 11, 2018
Closed
@rtannenbaum
Copy link
Contributor

Forgot we still need to test frontend, will reopen this

@rtannenbaum rtannenbaum reopened this Jan 11, 2018
rtannenbaum added a commit that referenced this issue Jan 11, 2018
@rtannenbaum
Customize Travis Slack notifications
e33b41c 
to be less spammy for #22
@rtannenbaum rtannenbaum mentioned this issue Jan 11, 2018
Merged
@rtannenbaum
Copy link
Contributor

@holachuy once we get the Jasmine/Karma tests passing it looks pretty easy to get Travis to run 'ng test'.

I sent a PR to fix a couple initial issues but I think I'd need to read up a bunch on Angular, Jasmine and Karma to get any further. Would it make more sense for you to fix them?

rtannenbaum added a commit that referenced this issue Jan 16, 2018
@rtannenbaum
Merge pull request #48 from google/ng-fixes
4e24df9 
A couple fixes to get 'ng test' working for #22
@holachuy holachuy mentioned this issue Jan 16, 2018
Merged
This was referenced Jan 24, 2018
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtannenbaum rtannenbaum

Labels
None yet
Projects
None yet
Milestone
Stable Infrastructure - Feb 2018
Development

Successfully merging a pull request may close this issue.

Make Travis run Angular end-to-end tests dtinit/data-transfer-project
2 participants
@bwillard @rtannenbaum