Issue-30: added json-schema implementation to validate response configs #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnunezalvarez
previously approved these changes
Oct 19, 2020
jonnunezalvarez
previously approved these changes
Oct 30, 2020
- Bumped supertest to version 6 - Bumped yargs to version 16 - Upgraded patch/minor versions
jonnunezalvarez
previously approved these changes
Oct 30, 2020
spik3r
approved these changes
Oct 30, 2020
| if (!SUPPORTED_METHODS.includes(method)) { | ||
| throw new Error(`Method ${method} is not supported.`); | ||
| } | ||
| var ajv = new Ajv({ schemas: [schema, responseSchema] }); |
There was a problem hiding this comment.
Whoops, yes, left-over from the example snippet. I'll get that in a future change.
| @@ -207,4 +207,47 @@ describe('AietesServer IT', () => { | |||
|
|
|||
| expect(res.status).toBe(404); | |||
| }); | |||
|
|
|||
| describe('Configuration errors', () => { | |||
| // TBD would be nice to test but terminates jest | |||
jonnunezalvarez
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30