Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FnArg::Ignored variant #644

Closed
dtolnay opened this issue Jun 9, 2019 · 1 comment
Closed

Remove FnArg::Ignored variant #644

dtolnay opened this issue Jun 9, 2019 · 1 comment
Labels
breaking change
Milestone
1.0

Comments

@dtolnay
Copy link
Owner

dtolnay commented Jun 9, 2019 

trait Trait {
    fn f(u8);
    //   ^^
}

This syntax has been removed in the 2018 edition. If someone still has this syntax in their code, there is a clear way to transition to syntax that work in both editions by prepending _: so we no longer need Syn to parse the old syntax.
@dtolnay dtolnay added this to the 1.0 milestone Jun 9, 2019
@dtolnay dtolnay mentioned this issue Jun 9, 2019
Closed
@dtolnay dtolnay mentioned this issue Jul 28, 2019
Merged
@dtolnay
Copy link
Owner Author

dtolnay commented Jul 28, 2019

Removed in 9b98fce.

@dtolnay dtolnay closed this as completed Jul 28, 2019
Centril added a commit to Centril/rust that referenced this issue Jul 28, 2019
@Centril
Rollup merge of rust-lang#63088 - dtolnay:anonymous, r=Centril
29c3778 
Remove anonymous_parameters from unrelated test

The parsing of anonymous_parameters is sufficiently covered by:

- [src/test/ui/issues/issue-13105.rs](https://github.com/rust-lang/rust/blob/023525dbda35748a10713471b948974b68a1c2cc/src/test/ui/issues/issue-13105.rs)
- [src/test/ui/issues/issue-13775.rs](https://github.com/rust-lang/rust/blob/023525dbda35748a10713471b948974b68a1c2cc/src/test/ui/issues/issue-13775.rs)
- [src/test/ui/issues/issue-34074.rs](https://github.com/rust-lang/rust/blob/023525dbda35748a10713471b948974b68a1c2cc/src/test/ui/issues/issue-34074.rs)

Removing anonymous_parameters from this test means fewer exclusions for me in dtolnay/syn#644.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@dtolnay