Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when parsing Ident encounters keyword #1415

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Mar 20, 2023

Before:

error: expected identifier
 --> dev/main.rs:4:8
  |
4 |     fn async() {}
  |        ^^^^^

After:

error: expected identifier, found keyword `async`
 --> dev/main.rs:4:8
  |
4 |     fn async() {}
  |        ^^^^^

This lines up with how Rust's error reporting in macro_rules handles the same situation.

macro_rules! path {
    ($p:path) => {};
}

path!(async);
error: expected identifier, found keyword `async`
 --> src/lib.rs:5:7
  |
5 | path!(async);
  |       ^^^^^ expected identifier, found keyword

@dtolnay dtolnay merged commit eaf6215 into master Mar 20, 2023
@dtolnay dtolnay deleted the identkeyword branch March 20, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant