Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legalization for expressions inside AssocConst #1654

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented May 15, 2024

Previously, if you created a GenericArgument::Const containing an expression that was not legal syntax within a path's const generics, such as:

impl Trait<1 + 1>
           ^^^^^

then Syn would automatically legalize it in the ToTokens impl to print with braces: impl Trait<{1 + 1}>. But for GenericArgument::AssocConst it was not doing this, although the syntax rules are the same.

impl Trait<ASSOC = 1 + 1>
                   ^^^^^

@dtolnay dtolnay merged commit 1d218f9 into master May 15, 2024
29 checks passed
@dtolnay dtolnay deleted the assocconst branch May 15, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant