Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyword as fmt argument #109

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Fix keyword as fmt argument #109

merged 3 commits into from
Nov 4, 2020

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Nov 4, 2020

The standard library's format macros allow keyword named argument, as in format_args!("{type}", type = 1). These were previously crashing thiserror.

error: proc-macro derive panicked
   --> tests/test_display.rs:269:14
    |
269 |     #[derive(Error, Debug)]
    |              ^^^^^
    |
    = help: message: called `Result::unwrap()` on an `Err` value: Error("expected identifier")

Presently crashes with:

    error: proc-macro derive panicked
       --> tests/test_display.rs:269:14
        |
    269 |     #[derive(Error, Debug)]
        |              ^^^^^
        |
        = help: message: called `Result::unwrap()` on an `Err` value: Error("expected identifier")
@dtolnay dtolnay merged commit 53bb2fb into master Nov 4, 2020
@dtolnay dtolnay deleted the keyword branch November 4, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant