Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Introduce new fc.noBias arbitrary #5050

Merged
merged 4 commits into from
Jun 6, 2024
Merged

✨ Introduce new fc.noBias arbitrary #5050

merged 4 commits into from
Jun 6, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jun 6, 2024

Description

While noBias used to be a thing directly provided on the arbitrary since version 1.1.0, we want to extract it as an independant arbitrary.

Such extraction would allow us to reduce the API surface of the arbitraries to a smaller subset of methods. Aim being to reduce as much of possible the API users will have to deal with from the arbitrary itself.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ✨ Introduce new features
  • Impacts: Deprecate noBias in the readme

While `noBias` used to be a thing directly provided on the arbitrary since version 1.1.0, we want to extract it as an independant arbitrary.

Such extraction would allow us to reduce the API surface of the arbitraries to a smaller subset of methods. Aim being to reduce as much of possible the API users will have to deal with from the arbitrary itself.
Copy link

codesandbox-ci bot commented Jun 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ad8c183:

Sandbox Source
@fast-check/examples Configuration

@dubzzz dubzzz enabled auto-merge (squash) June 6, 2024 01:59
Copy link

codesandbox-ci bot commented Jun 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0fe9e70:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

github-actions bot commented Jun 6, 2024

👋 A preview of the new documentation is available at: http://666118ff721e7c306197c4cc--dubzzz-fast-check.netlify.app

Copy link
Contributor

github-actions bot commented Jun 6, 2024

👋 A preview of the new documentation is available at: http://666153d9063eb0582507e5a7--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit 2a06c3d into main Jun 6, 2024
73 of 74 checks passed
@dubzzz dubzzz deleted the no-bias branch June 6, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant