Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support {REQUESTS, CURL}_CA_BUNDLE env variables #146

Merged
merged 2 commits into from
May 30, 2021
Merged

Support {REQUESTS, CURL}_CA_BUNDLE env variables #146

merged 2 commits into from
May 30, 2021

Conversation

ducaale
Copy link
Owner

@ducaale ducaale commented May 29, 2021 •
edited
Loading

This PR adds support for HTTPie's undocumented REQUESTS_CA_BUNDLE and CURL_CA_BUNDLE environment variables that behave similarly to the --verify PATH flag.

See #4 (comment)

@blyxxyz
Copy link
Collaborator

blyxxyz commented May 29, 2021

These variables will be picked up by to_curl, I don't think we want that. Maybe they should go in main.rs?

I'd mention in a comment as precedent that requests also looks at CURL_CA_BUNDLE, as looking at other libraries' environment variables is a bit weird.

@ducaale ducaale changed the base branch from master to develop May 30, 2021 13:31
@ducaale ducaale requested a review from blyxxyz May 30, 2021 19:11
@ducaale ducaale merged commit 774d36d into develop May 30, 2021
@ducaale ducaale deleted the verify-env branch May 30, 2021 19:15
@ducaale ducaale mentioned this pull request Sep 12, 2021
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxxyz blyxxyz blyxxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ducaale @blyxxyz