Do not hardcode /tmp in install script #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran on mktemp -dt xh.XXXXXX
/var/folders/wm/lp071lgd09nb3_mv_9pthcs00000gn/T/xh.XXXXXX.a6efJLUf |
|
Thank you, that looks good. It's a bit weird that it ignores the Xes but that doesn't really matter. |
ducaale
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems don't have
/tmpat that location.Additionally,
XXXXXXis the maximum number of Xes that busybox'smktempreplaces, so I reduced it to that.Tested on Debian, Alpine, and Termux. I think it works on macOS, but its
-tflag works differently, so it should be tested there too.(This is not enough to get xh itself working in Termux on my phone, because of dynamic linking. Maybe we should switch to
arm-unknown-linux-musleabihf, a binary for that target does run. But even then the DNS is broken.)