Enable check-status by default #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducaale
commented
Jun 11, 2021
blyxxyz
requested changes
Jun 11, 2021
this will be automatically enabled if the binary name is either http or https
ducaale
commented
Jun 12, 2021
src/cli.rs
Outdated
Comment on lines
398
to
400
| if matches!(bin_name, Some("http") | Some("https")) { | ||
| cli.strict_compat_mode = true; | ||
| } |
There was a problem hiding this comment.
Maybe I should also add an env for enabling strict_compat_mode? This could be helpful for testing purposes and for users who have installed xh via a package manager.
There was a problem hiding this comment.
Update: I have now added XH_HTTPIE_COMPAT_MODE env variable.
blyxxyz
requested changes
Jun 12, 2021
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
blyxxyz
approved these changes
Jun 12, 2021
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--check-statusby default if strict compatibility mode is not on.Resolves #144