Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send and display headers as title case #167

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Send and display headers as title case #167

merged 3 commits into from
Aug 4, 2021

Conversation

blyxxyz
Copy link
Collaborator

@blyxxyz blyxxyz commented Aug 4, 2021

Resolves #166.

ducaale
ducaale reviewed Aug 4, 2021
View reviewed changes
Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have two minor comments

README.md Outdated Show resolved Hide resolved
src/printer.rs Outdated Show resolved Hide resolved
ducaale
ducaale approved these changes Aug 4, 2021
View reviewed changes
Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ducaale ducaale merged commit f7f06c1 into ducaale:develop Aug 4, 2021
@blyxxyz blyxxyz deleted the title-case-headers branch August 4, 2021 21:58
@rburgst
Copy link

rburgst commented Jan 11, 2023

IMHO sending headers as title case by default is somewhat unexpected (and certainly different from how httpie does it.
Note that by RFC headers should be case insensitive therefore, on the server you should usually only expect lowercase headers.
Now if I send a request

xh http://localhost:3000 foo:bar

xh will actually send Foo: bar to the server which is unexpected IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducaale ducaale ducaale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blyxxyz @rburgst @ducaale