Replace httpmock with hyper

[ducaale]

Also introduces a feature flag named online-tests that can be used to filter out tests that require an internet connection.

Resolves #186

[ducaale]

See https://discord.com/channels/500028886025895936/670880858630258689/906845871021383700

[blyxxyz]

I'm not in that server (and can't tell which server it is) so I can't view that message

[ducaale]

It is in tokio's discord server which has channels for hyper, h3, reqwest and more.

[blyxxyz]

The problem with x86_64-unknown-linux-gnu seems to be that Ubuntu 20.04 by default disables the ciphers TLS1.1 needs to function, even if you enable that TLS version. HTTPie also suffers from this but it has a --ciphers flag that can presumably help. IIRC reqwest and native-tls don't let you set the cipher suite.

An easy fix is to enable the vendored feature on the openssl crate. That's not something we'd want to do by default but it could make sense to offer outside of testing.

An even easier fix is to change the good_tls_version_nativetls test to test TLS1.2 instead. I think that's the best option for now.

[blyxxyz]

I managed to get the integration tests working on ARM:

/// Cargo-cross for ARM runs tests using qemu.
///
/// It sets an environment variable like this:
/// CARGO_TARGET_ARM_UNKNOWN_LINUX_GNUEABIHF_RUNNER=qemu-arm
fn find_runner() -> Option<String> {
    for (key, value) in std::env::vars() {
        if key.starts_with("CARGO_TARGET_") && key.ends_with("_RUNNER") && !value.is_empty() {
            return Some(value);
        }
    }
    None
}

fn get_base_command() -> Command {
    let mut cmd;
    let path = assert_cmd::cargo::cargo_bin("xh");
    if let Some(runner) = find_runner() {
        cmd = Command::new(runner);
        cmd.arg(path);
    } else {
        cmd = Command::new(path);
    }
    cmd.env("HOME", "");
    #[cfg(target_os = "windows")]
    cmd.env("XH_TEST_MODE_WIN_HOME_DIR", "");
    cmd
}

[ducaale]

Woohoo! I can't believe that integration tests are finally working for ARM. How does the solution work? are there any docs I can refer to?

Oh, and should we get rid of the integration-tests feature flag?

[blyxxyz]

I don't know if it's documented anywhere (and how safely we can rely on it).

Cross uses qemu to run binaries for other architectures. You prefix a command with e.g. qemu-arm and then qemu translates it for your host system.

Cross fiddles with cargo to make sure your test binaries are run through qemu. But we build our own commands and they aren't fixed automatically.

I had a suspicion it was something like this, and discovered the details and this solution by panicking in the tests with the output of pgrep -af . and env.

I think this would've worked before cross-rs/cross#122, when it still used binfmt and didn't need to make the runner explicit.

Oh, and should we get rid of the integration-tests feature flag?

Yeah, I think we no longer have a need for it.

[blyxxyz]

This looks great! I also like the online-tests feature.

I noticed some inconsistency between writing http::Response and hyper::Response, use http::Response; could clean things up. But that doesn't really matter.

[blyxxyz]

I'm not in that server (and can't tell which server it is) so I can't view that message

[blyxxyz]

I'm ok with merging now and re-enabling the test after chromium/badssl.com#482 is fixed.