-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to_curl: Improve quoting, update options #200
Conversation
The ARM tests get stuck on |
All tests have passed now (there is If ARM tests start to fail again, perhaps we could try limiting the number of parallel |
I haven't done a new |
Yup, I can confirm the quoting works correctly in Powershell now.
|
We do this by switching from shell-escape to os_display. That one doesn't quote unless necessary and supports invalid unicode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 🎉
The quoting done by shell-escape is very simple and conservative, not great for user-readable output. I recently wrote
os_display
which I think is more suitable here.I also went through all the options to bring them up to date.