Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight text line by line instead of all at once #228

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Highlight text line by line instead of all at once #228

merged 2 commits into from
Feb 2, 2022

Conversation

blyxxyz
Copy link
Collaborator

@blyxxyz blyxxyz commented Feb 1, 2022

A while ago I changed it to highlight the full body at once, but that can actually be a lot slower.

For example, fetching a local copy of this page goes from 200ms to 100ms after this change.

@ducaale ducaale merged commit 94fc80e into ducaale:develop Feb 2, 2022
@blyxxyz blyxxyz deleted the incremental-highlight branch February 2, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducaale ducaale ducaale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blyxxyz @ducaale