-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Windows ODBC tests to CI #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiadegraaf
force-pushed
the
CI-adjustents
branch
2 times, most recently
from
June 26, 2024 09:26
213445d
to
b69ef85
Compare
maiadegraaf
force-pushed
the
CI-adjustents
branch
from
June 26, 2024 10:55
040ccf4
to
b36c6d9
Compare
carlopi
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
maiadegraaf
force-pushed
the
CI-adjustents
branch
from
June 26, 2024 12:02
4a7b540
to
734ffaa
Compare
maiadegraaf
force-pushed
the
CI-adjustents
branch
from
June 27, 2024 07:39
743b9b9
to
01d3c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows CI was missing the
ODBC-Connection
tests, and wasn't creatingodbc_install.exe
which is neccisary to install ODBC on windows. Now all items inbuild/release/bin/Release
are included in the deployment of the windows artifacts, and all the ODBC tests are run on windows.