Jdbc enable httpfs

[jmbradshaw79]

Initial take on using BUILD_HTTPFS to also include httpfs extension when building tools/jdbc shared object libs for both osx and linux amd64.

[jmbradshaw79]

@Mytherin first time contributor here. Looks like the last run was all good minus an intermittent test failure re: python and arrow file download parsing. Merged master in again to trigger a new run. Anything else I need to take care of please let me know!

[Mytherin]

Thanks for the PR!

This looks good to me in principle. Perhaps we should use the extension_helper.hpp file and CMake macros (add_extension_definitions() and link_extension_libraries) for the JDBC library as well. That way all the extensions that are enabled will be automatically compiled into the JDBC library.

Otherwise I can potentially see linking issues when deploying the .jar file (e.g. #1741). I'm not well versed in Java packaging (and Java in general) though, perhaps @hannesmuehleisen has a more informed opinion here.

[jmbradshaw79]

Thanks for the tips, still getting familiar with the code base. Will take a crack at making those changes this week.

[hannes]

This is not going to be the correct include path for OpenSSL on most platforms

[jmbradshaw79]

My understanding is this is only relevant to the xcode-release build job on macos. The linux-release-64 did not require additional settings as I believe the correct reference is already set in the environment.

[jmbradshaw79]

@Mytherin I did update to use extension helper and cmake macros but you are spot on that it has the same linking issues while running on systems without libssl.so.1.0.0 installed. Not 100% on how to proceed. Perhaps now that it uses the extension helper it can take advantage of the fix in the future. I am not sure if statically linking libssl is a good alternative but it may benefit those who want to run on systems that have libssl.so.1.1 vs libssl.so.1.0.0. Thoughts?

[hannes]

This will be superseded by #2569