Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapfunctions: map_entries, map_values, map_keys #6522

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

LindsayWray
Copy link

This PR adds three additional map_functions: map_entries, map_values, map_keys.

The code is largely yoinked from @Tishj closed PR #5009
I’ve only altered it to now work with the internal map changes

Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, much better than my old version!

Also this has a lot more tests than there originally were 👍

@Mytherin Mytherin changed the base branch from feature to master March 3, 2023 13:19
@Mytherin Mytherin merged commit f5c0dce into duckdb:master Mar 3, 2023
@Mytherin
Copy link
Collaborator

Mytherin commented Mar 3, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants