Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADS: Lint Rules #2697

Merged
merged 21 commits into from
Jan 30, 2023
Merged

ADS: Lint Rules #2697

merged 21 commits into from
Jan 30, 2023

Commits on Jan 30, 2023

  1. feature/david/ads/lint_rules

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    0c0e795 View commit details
    Browse the repository at this point in the history

  2. clean up old files and lint rules

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    eacf847 View commit details
    Browse the repository at this point in the history

  3. Added lint exception DeprecatedWidgetInXml to widget layouts

    @nalcalag @malmstein
    nalcalag authored and malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7e51033 View commit details
    Browse the repository at this point in the history

  4. clean up legacy buttons

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    afd8908 View commit details
    Browse the repository at this point in the history

  5. cleaning up buttons

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    9158e93 View commit details
    Browse the repository at this point in the history

  6. supressing autofill warnings for now

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    0b9c2d9 View commit details
    Browse the repository at this point in the history

  7. migrating internal vpn

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    e59b017 View commit details
    Browse the repository at this point in the history

  8. more cleanup of legacy widgets

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c307bfe View commit details
    Browse the repository at this point in the history

  9. cleaning up lint issues

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    bb557d2 View commit details
    Browse the repository at this point in the history

  10. create new Skeleton View

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    ccb1519 View commit details
    Browse the repository at this point in the history

  11. kotlin format

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2591eda View commit details
    Browse the repository at this point in the history

  12. added rule to treat wrong style names

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7b97916 View commit details
    Browse the repository at this point in the history

  13. added lint rule to avoid height and width in styles

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    6f1a028 View commit details
    Browse the repository at this point in the history

  14. added new style detector to the registry

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    cf55d49 View commit details
    Browse the repository at this point in the history

  15. added new rule for colors

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2ab54c5 View commit details
    Browse the repository at this point in the history

  16. ADS: Code and Attributes cleanup (#2746) 

    Task/Issue URL:
https://app.asana.com/0/1174433894299346/1203720277615468

### Description

### Steps to test this PR
Background
Task to track the work of removing unnecessary code in the app

Scope:
Attributes no longer in use
Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc
Remove unused styles
    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    498a6dc View commit details
    Browse the repository at this point in the history

  17. ADS: Maestro (#2783) 

    Task/Issue URL:
https://app.asana.com/0/1174433894299346/1203827857866586

### Description
Adds a Maestro test to open the ADS Preview pages whenever a change to a
Component happens


### Steps to test this PR

_Non Android 13 device_
- [ ] Fresh install InternalRelease or InternalDebug version
- [ ] Run maestro tests locally (❯ maestro test
.maestro/ads_preview_flows/1-_design-system-components.yaml)


---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1203827857866586
    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c2d535e View commit details
    Browse the repository at this point in the history

  18. remove old baselines

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c57810c View commit details
    Browse the repository at this point in the history

  19. updated baseline files

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    5906404 View commit details
    Browse the repository at this point in the history

  20. fixed lint tests

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c4a953b View commit details
    Browse the repository at this point in the history

  21. cleanup

    @malmstein
    malmstein committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    50229da View commit details
    Browse the repository at this point in the history