Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADS: Code and Attributes cleanup #2746

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Jan 19, 2023

Task/Issue URL: https://app.asana.com/0/1174433894299346/1203720277615468

Description

Steps to test this PR

Background
Task to track the work of removing unnecessary code in the app

Scope:
Attributes no longer in use
Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc
Remove unused styles

@malmstein malmstein force-pushed the 01-09-feature/david/ads/lint_rules branch from b99c919 to 74de1f6 Compare January 20, 2023 12:21
@malmstein malmstein force-pushed the 01-19-feature/david/ads/code_cleanup branch from 56d06dd to 1316ac0 Compare January 20, 2023 12:21
@malmstein malmstein force-pushed the 01-09-feature/david/ads/lint_rules branch from 74de1f6 to 275c42e Compare January 20, 2023 14:54
@malmstein malmstein force-pushed the 01-19-feature/david/ads/code_cleanup branch from 1316ac0 to 6656b85 Compare January 20, 2023 14:54
@malmstein malmstein marked this pull request as ready for review January 24, 2023 11:15
@malmstein malmstein force-pushed the 01-09-feature/david/ads/lint_rules branch from 275c42e to 8040b32 Compare January 24, 2023 11:19
@malmstein malmstein force-pushed the 01-19-feature/david/ads/code_cleanup branch from 25d0e01 to 2a3a6b4 Compare January 24, 2023 11:19
@malmstein malmstein force-pushed the 01-09-feature/david/ads/lint_rules branch from 37afe0a to cd77d79 Compare January 25, 2023 10:42
@malmstein malmstein force-pushed the 01-19-feature/david/ads/code_cleanup branch from 2a3a6b4 to 3d5c498 Compare January 25, 2023 10:42
@malmstein malmstein force-pushed the 01-19-feature/david/ads/code_cleanup branch from 3d5c498 to ccbc071 Compare January 25, 2023 15:57
@malmstein malmstein mentioned this pull request Jan 25, 2023
2 tasks
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🤩 I've been testing it and everything looks fine 👍

@malmstein malmstein merged commit 54ab29f into 01-09-feature/david/ads/lint_rules Jan 27, 2023
@malmstein malmstein deleted the 01-19-feature/david/ads/code_cleanup branch January 27, 2023 12:31
malmstein added a commit that referenced this pull request Jan 27, 2023
Task/Issue URL:
https://app.asana.com/0/1174433894299346/1203720277615468

### Description

### Steps to test this PR
Background
Task to track the work of removing unnecessary code in the app

Scope:
Attributes no longer in use
Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc
Remove unused styles
malmstein added a commit that referenced this pull request Jan 27, 2023
Task/Issue URL:
https://app.asana.com/0/1174433894299346/1203720277615468

### Description

### Steps to test this PR
Background
Task to track the work of removing unnecessary code in the app

Scope:
Attributes no longer in use
Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc
Remove unused styles
@malmstein malmstein mentioned this pull request Jan 27, 2023
2 tasks
malmstein added a commit that referenced this pull request Jan 30, 2023
Task/Issue URL:
https://app.asana.com/0/1174433894299346/1203720277615468

### Description

### Steps to test this PR
Background
Task to track the work of removing unnecessary code in the app

Scope:
Attributes no longer in use
Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc
Remove unused styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants