-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADS: Code and Attributes cleanup #2746
Merged
malmstein
merged 18 commits into
01-09-feature/david/ads/lint_rules
from
01-19-feature/david/ads/code_cleanup
Jan 27, 2023
Merged
ADS: Code and Attributes cleanup #2746
malmstein
merged 18 commits into
01-09-feature/david/ads/lint_rules
from
01-19-feature/david/ads/code_cleanup
Jan 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2023
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
January 20, 2023 12:21
b99c919
to
74de1f6
Compare
malmstein
force-pushed
the
01-19-feature/david/ads/code_cleanup
branch
from
January 20, 2023 12:21
56d06dd
to
1316ac0
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
January 20, 2023 14:54
74de1f6
to
275c42e
Compare
malmstein
force-pushed
the
01-19-feature/david/ads/code_cleanup
branch
from
January 20, 2023 14:54
1316ac0
to
6656b85
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
January 24, 2023 11:19
275c42e
to
8040b32
Compare
malmstein
force-pushed
the
01-19-feature/david/ads/code_cleanup
branch
from
January 24, 2023 11:19
25d0e01
to
2a3a6b4
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
January 25, 2023 10:42
37afe0a
to
cd77d79
Compare
malmstein
force-pushed
the
01-19-feature/david/ads/code_cleanup
branch
from
January 25, 2023 10:42
2a3a6b4
to
3d5c498
Compare
malmstein
force-pushed
the
01-19-feature/david/ads/code_cleanup
branch
from
January 25, 2023 15:57
3d5c498
to
ccbc071
Compare
nalcalag
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🤩 I've been testing it and everything looks fine 👍
malmstein
added a commit
that referenced
this pull request
Jan 27, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203720277615468 ### Description ### Steps to test this PR Background Task to track the work of removing unnecessary code in the app Scope: Attributes no longer in use Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc Remove unused styles
malmstein
added a commit
that referenced
this pull request
Jan 27, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203720277615468 ### Description ### Steps to test this PR Background Task to track the work of removing unnecessary code in the app Scope: Attributes no longer in use Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc Remove unused styles
malmstein
added a commit
that referenced
this pull request
Jan 30, 2023
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203720277615468 ### Description ### Steps to test this PR Background Task to track the work of removing unnecessary code in the app Scope: Attributes no longer in use Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc Remove unused styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203720277615468
Description
Steps to test this PR
Background
Task to track the work of removing unnecessary code in the app
Scope:
Attributes no longer in use
Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc
Remove unused styles